Make get_bounds_as_ndarray device safe
#1567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42060124 |
Codecov Report
@@ Coverage Diff @@
## main #1567 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 153 153
Lines 13562 13562
=========================================
Hits 13562 13562
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Balandat
approved these changes
Dec 15, 2022
|
Should we add a test for this on both CPU and GPU? |
Summary: Pull Request resolved: pytorch#1567 Issue raised in pytorch#1566. The `bounds` can be a `Dict[str, Tuple[Tensor, Tensor]]` where the tensors live on GPU, which leads to a device error when trying to assign them to a numpy array. Reviewed By: Balandat Differential Revision: D42060124 fbshipit-source-id: 549a0f220edcc34ecdeb2813a2978bde7cab4b6c
saitcakmak
force-pushed
the
export-D42060124
branch
from
2df50ae to
d01be04
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42060124 |
|
This pull request has been merged in 6d120db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue raised in #1566.
The
boundscan be aDict[str, Tuple[Tensor, Tensor]]where the tensors live on GPU, which leads to a device error when trying to assign them to a numpy array.Differential Revision: D42060124