Support for outcome transforms that return a TransformedPosterior in ModelListGP #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42019721 |
Codecov Report
@@ Coverage Diff @@
## main #1563 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 153 153
Lines 13631 13643 +12
=========================================
+ Hits 13631 13643 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Dec 14, 2022
…ModelListGP (pytorch#1563) Summary: Pull Request resolved: pytorch#1563 Replaces D41860896, but adds support for the outcome transforms that weren't working for `ModelListGP.posterior` by calling `ModelList.posterior`. See pytorch#1519 for more context on the issue that this is fixing. Reviewed By: Balandat Differential Revision: D42019721 fbshipit-source-id: 1db199eb1b54096d06d9f9aaa1ef106ef2482a28
esantorella
force-pushed
the
export-D42019721
branch
from
7a0bb8c to
5ddd5c7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42019721 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Dec 14, 2022
…ModelListGP (pytorch#1563) Summary: Pull Request resolved: pytorch#1563 Replaces D41860896, but adds support for the outcome transforms that weren't working for `ModelListGP.posterior` by calling `ModelList.posterior`. See pytorch#1519 for more context on the issue that this is fixing. Differential Revision: D42019721 fbshipit-source-id: 6a373b1fffdfde8001f8ea26fe1a4b4e89a6c9e2
esantorella
force-pushed
the
export-D42019721
branch
from
5ddd5c7 to
66d4c3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42019721 |
esantorella
force-pushed
the
export-D42019721
branch
from
66d4c3e to
579ac33
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Dec 14, 2022
…ModelListGP (pytorch#1563) Summary: Pull Request resolved: pytorch#1563 Replaces D41860896, but adds support for the outcome transforms that weren't working for `ModelListGP.posterior` by calling `ModelList.posterior`. See pytorch#1519 for more context on the issue that this is fixing. Reviewed By: saitcakmak Differential Revision: D42019721 fbshipit-source-id: 0255194768151e6588a449db4d2a92cfabfce6d4
|
This pull request was exported from Phabricator. Differential Revision: D42019721 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Dec 14, 2022
…ModelListGP (pytorch#1563) Summary: Pull Request resolved: pytorch#1563 Replaces D41860896, but adds support for the outcome transforms that weren't working for `ModelListGP.posterior` by calling `ModelList.posterior`. See pytorch#1519 for more context on the issue that this is fixing. Reviewed By: saitcakmak Differential Revision: D42019721 fbshipit-source-id: 2da3e5acd4a33a54fdc5d7535b1646818304e7c0
esantorella
force-pushed
the
export-D42019721
branch
from
579ac33 to
ab5843b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42019721 |
…ModelListGP (pytorch#1563) Summary: Pull Request resolved: pytorch#1563 Replaces D41860896, but adds support for the outcome transforms that weren't working for `ModelListGP.posterior` by calling `ModelList.posterior`. See pytorch#1519 for more context on the issue that this is fixing. Reviewed By: saitcakmak Differential Revision: D42019721 fbshipit-source-id: 762a3e042911e3b5e0f18a000ab00b993be55e58
esantorella
force-pushed
the
export-D42019721
branch
from
ab5843b to
9ca8715
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42019721 |
|
This pull request has been merged in 5066540. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replaces D41860896, but adds support for the outcome transforms that weren't working for
ModelListGP.posteriorby callingModelList.posterior.See #1519 for more context on the issue that this is fixing.
Reviewed By: Balandat
Differential Revision: D42019721