Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout ability to gen_* functions #1562

Closed
wants to merge 1 commit into from
Closed

Add timeout ability to gen_* functions #1562

wants to merge 1 commit into from

Conversation

Balandat
Copy link
Contributor

Summary: Exposes the ability to pass a timeout_sec kwarg to gen_candidates_scipy and gen_candidates_torch that allows to stop the optimization after running for more than timeout_sec seconds.

Differential Revision: D42024857

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Dec 14, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42024857

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42024857

Balandat added a commit to Balandat/botorch that referenced this pull request Dec 28, 2022
@Balandat @facebook-github-bot
Add timeout ability to gen_* functions (pytorch#1562)
2657240 
Summary:
Pull Request resolved: pytorch#1562

Exposes the ability to pass a `timeout_sec` kwarg to `gen_candidates_scipy` and `gen_candidates_torch` that allows to stop the optimization after running for more than `timeout_sec` seconds.

Differential Revision: D42024857

fbshipit-source-id: bb4f2287d19bac96881029678e8458cae646ef66
@codecov
Copy link

codecov bot commented Dec 28, 2022 •
edited
Loading

Codecov Report

Merging #1562 (412acaf) into main (10fb0ce) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1562   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          154       154           
  Lines        13741     13754   +13     
=========================================
+ Hits         13741     13754   +13
Impacted Files Coverage Δ
botorch/generation/gen.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Balandat added a commit to Balandat/botorch that referenced this pull request Dec 28, 2022
@Balandat @facebook-github-bot
Add timeout ability to gen_* functions (pytorch#1562)
8cb3ea0 
Summary:
Pull Request resolved: pytorch#1562

Exposes the ability to pass a `timeout_sec` kwarg to `gen_candidates_scipy` and `gen_candidates_torch` that allows to stop the optimization after running for more than `timeout_sec` seconds.

Differential Revision: D42024857

fbshipit-source-id: 1fec382ce1dfa80e54383eaf8a5edec777726d25
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42024857

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42024857

Balandat added a commit to Balandat/botorch that referenced this pull request Dec 29, 2022
@Balandat @facebook-github-bot
Add timeout ability to gen_* functions (pytorch#1562)
97db536 
Summary:
Pull Request resolved: pytorch#1562

Exposes the ability to pass a `timeout_sec` kwarg to `gen_candidates_scipy` and `gen_candidates_torch` that allows to stop the optimization after running for more than `timeout_sec` seconds.

Differential Revision: D42024857

fbshipit-source-id: ffb52af4cdfcd7e00cfd7ab6f82ed1fb7979a888
@Balandat
Copy link
Contributor Author

Ugh the tutorial failure here is kind of a pain - the tutorial is importing a context manager from ax, but that context manager mocks things deep in botorch that this PR changes, and the context manager itself is only updated as part of the diff that contains this PR. Such circular dependency issue here is not a great design and we generally shouldn't be importing things from Ax in botorch (the fact that we have Ax tutorials makes this hard but for reasonably high-level behavior this should be ok).

I think what I might do is add a minimize function back in as an alias that raises a DeprecationWarning that we can remove after the next Ax release

Balandat added a commit to Balandat/botorch that referenced this pull request Dec 30, 2022
@Balandat @facebook-github-bot
Add timeout ability to gen_* functions (pytorch#1562)
ea2a59a 
Summary:
Pull Request resolved: pytorch#1562

Exposes the ability to pass a `timeout_sec` kwarg to `gen_candidates_scipy` and `gen_candidates_torch` that allows to stop the optimization after running for more than `timeout_sec` seconds.

Reviewed By: esantorella

Differential Revision: D42024857

fbshipit-source-id: b4804efef87f42cfb49886cbcf40632095da01c3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42024857

@Balandat @facebook-github-bot
Add timeout ability to gen_* functions (pytorch#1562)
412acaf 
Summary:
Pull Request resolved: pytorch#1562

Exposes the ability to pass a `timeout_sec` kwarg to `gen_candidates_scipy` and `gen_candidates_torch` that allows to stop the optimization after running for more than `timeout_sec` seconds.

Reviewed By: esantorella

Differential Revision: D42024857

fbshipit-source-id: f6d6dc96c3f3fac6b212e0b2b90213efd2217be0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42024857

@Balandat Balandat mentioned this pull request Dec 30, 2022
Closed
Balandat added a commit to Balandat/Ax that referenced this pull request Dec 30, 2022
@Balandat @facebook-github-bot
Add timeout ability to gen_* functions (facebook#1562)
51de25e 
Summary:
X-link: pytorch/botorch#1562

Exposes the ability to pass a `timeout_sec` kwarg to `gen_candidates_scipy` and `gen_candidates_torch` that allows to stop the optimization after running for more than `timeout_sec` seconds.

Reviewed By: esantorella

Differential Revision: D42024857

fbshipit-source-id: 0d4d96a7f17161993775a777b8b148fdcb149017
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d23c492.

facebook-github-bot pushed a commit to facebook/Ax that referenced this pull request Dec 30, 2022
@Balandat @facebook-github-bot
Add timeout ability to gen_* functions (#1352)
733bdb7 
Summary:
Pull Request resolved: #1352

X-link: pytorch/botorch#1562

Exposes the ability to pass a `timeout_sec` kwarg to `gen_candidates_scipy` and `gen_candidates_torch` that allows to stop the optimization after running for more than `timeout_sec` seconds.

Reviewed By: esantorella

Differential Revision: D42024857

fbshipit-source-id: ffe12673954b40e803ae86a6a1184b9d2909e69c
@Balandat Balandat deleted the export-D42024857 branch March 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Balandat @facebook-github-bot