Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cont_kernel_factory signature #1557

Closed
wants to merge 1 commit into from

Conversation

jduerholt
Copy link
Contributor

Motivation

There was a bug in the signature and docstring for the cont_kernel_factory argument in MixedSingleTaskGP. The batch_shape argument was missing.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Not needed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1557 (e945302) into main (041125f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1557   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          153       153           
  Lines        13604     13604           
=========================================
  Hits         13604     13604           
Impacted Files Coverage Δ
botorch/models/gp_regression_mixed.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot
Copy link
Contributor

@SebastianAment has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SebastianAment
Copy link
Contributor

Thank you for adding this @jduerholt! We'll wait until the internal tests finish, but this looks good to me.

@jduerholt
Copy link
Contributor Author

Thank you for adding this @jduerholt! We'll wait until the internal tests finish, but this looks good to me.

Just out of curiosity: What are these internal additional tests? I was always wondering ... :D

@saitcakmak
Copy link
Contributor

Just out of curiosity: What are these internal additional tests? I was always wondering ... :D

It includes test for some other OSS projects like Ax & AEPsych that depend on BoTorch and other internal projects that build on Ax & BoTorch. We also run BoTorch unit tests on both CPU and GPU (GitHub CI is CPU only) and also test some internal only BoTorch features (experimental or haven't made it to OSS due to limited bandwidth on our end).

@facebook-github-bot
Copy link
Contributor

@SebastianAment merged this pull request in fbcd6dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants