Fix RFF bug when using FixedNoiseGP models #1528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `_model.likelihood.noise` is a `... x d`-dim tensor for fixed noise models with `d`-dimensional `train_X`. This leads to errors when constructing the RFF. This updates the `sigma_sq` to use the mean across the input dimensions, which was used prior to pytorch#1336. Differential Revision: D41568680 fbshipit-source-id: fb9b422582cc57fb35859d5d3b20c92c140ee38b
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41568680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
_model.likelihood.noiseis a... x d-dim tensor for fixed noise models withd-dimensionaltrain_X. This leads to errors when constructing the RFF. This updates thesigma_sqto use the mean across the input dimensions, which was used prior to #1336.Differential Revision: D41568680