Replace deprecated np.bool with equivalent bool #1524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
esantorella
added
bug
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #1524 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 149 149
Lines 12936 12935 -1
=========================================
- Hits 12936 12935 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
np.boolhas been removed in numpy 1.24.0, currently only available as a pre-release. This caused failures like this onenp.boolhas always been equivalent tobool, so I replaced it withbool.Surprisingly (to me), we are only running that version of numpy in the tutorials and are using an older version of unit tests, so tests all passed.
Test Plan
Added a test that the dtype mapping in
torch_to_numpy_dtype_dictmatches the behavior of torch.numpy()