Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding on docstrings in BoTorch Model #1496

Closed
wants to merge 4 commits into from

Conversation

esantorella
Copy link
Member

Summary: Added content to docstrings in BoTorch Model to help people who may either be unfamiliar with torch Module or with what its methods (such as "forward") mean in the context of BoTorch models.

Differential Revision: D41221005

Summary: Added content to docstrings in BoTorch `Model` to help people who may either be unfamiliar with torch `Module` or with what its methods (such as "forward") mean in the context of BoTorch models.

Differential Revision: D41221005

fbshipit-source-id: 165ce67766acebc2f20fbd7dc16f5a5a193324b3
@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Nov 11, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41221005

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1496 (c6b7142) into main (7613cd2) will not change coverage.
The diff coverage is n/a.

❗ Current head c6b7142 differs from pull request most recent head 9335ba9. Consider uploading reports for the commit 9335ba9 to get more accurate results

@@            Coverage Diff            @@
##              main     #1496   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          134       134           
  Lines        12402     12402           
=========================================
  Hits         12402     12402           
Impacted Files Coverage Δ
botorch/models/model.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@esantorella esantorella self-assigned this Nov 11, 2022
@facebook-github-bot
Copy link
Contributor

@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants