Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating torch.triangular_solve #1494

Closed
wants to merge 1 commit into from

Conversation

SebastianAment
Copy link
Contributor

Summary: Deprecating torch.triangular_solve in favor of torch.linalg.solve_triangular. Note: the order of the arguments change.

Reviewed By: Balandat

Differential Revision: D39324704

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Nov 10, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39324704

Summary:
Pull Request resolved: pytorch#1494

Deprecating `torch.triangular_solve` in favor of `torch.linalg.solve_triangular`. Note: the order of the arguments change.

Reviewed By: Balandat

Differential Revision: D39324704

fbshipit-source-id: 8f0103b12dabef34e0ab536eeaa66445d39aa4a8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39324704

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1494 (bddbf90) into main (7eada74) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1494   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          134       134           
  Lines        12409     12402    -7     
=========================================
- Hits         12409     12402    -7     
Impacted Files Coverage Δ
botorch/utils/gp_sampling.py 100.00% <100.00%> (ø)
botorch/utils/low_rank.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants