BoxDecomposition cleanup #1490
Closed
BoxDecomposition cleanup #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41172490 |
Codecov Report
@@ Coverage Diff @@
## main #1490 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 134 134
Lines 12402 12407 +5
=========================================
+ Hits 12402 12407 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request was exported from Phabricator. Differential Revision: D41172490 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Nov 10, 2022
Summary: Pull Request resolved: pytorch#1490 - Change `compute_hypervolume` so that each BoxDecomposition subclass uses shared logic for the no-data case - [debatable] When `Y` is `None`, functions of Y like `box_decomp._neg_Y` are `None` rather than being unset attributes, so we do "if self._neg_Y is None" rather than catching an AttributeError. This makes catching type errors easier since otherwise Pyre is unhappy about references to the potentially-uninitialized attribute. - Took out unnecessary "register_buffer" calls (this happens automatically with `torch.nn.Module.setattr`) Differential Revision: D41172490 fbshipit-source-id: 01e3e159846b5b6cbd77763bdec00ee5d86aa50d
esantorella
force-pushed
the
export-D41172490
branch
from
2bfc551 to
95fe8bc
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Nov 11, 2022
Summary: Pull Request resolved: pytorch#1490 - Change `compute_hypervolume` so that each BoxDecomposition subclass uses shared logic for the no-data case - [debatable] When `Y` is `None`, functions of Y like `box_decomp._neg_Y` are `None` rather than being unset attributes, so we do "if self._neg_Y is None" rather than catching an AttributeError. This makes catching type errors easier since otherwise Pyre is unhappy about references to the potentially-uninitialized attribute. - Took out unnecessary "register_buffer" calls (this happens automatically with `torch.nn.Module.setattr`) Differential Revision: D41172490 fbshipit-source-id: 356485c84b2d6bc85b20ed34b7247ba1478057d2
esantorella
force-pushed
the
export-D41172490
branch
from
95fe8bc to
17cc28a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41172490 |
Summary: Pull Request resolved: pytorch#1490 - Change `compute_hypervolume` so that each BoxDecomposition subclass uses shared logic for the no-data case - [debatable] When `Y` is `None`, functions of Y like `box_decomp._neg_Y` are `None` rather than being unset attributes, so we do "if self._neg_Y is None" rather than catching an AttributeError. This makes catching type errors easier since otherwise Pyre is unhappy about references to the potentially-uninitialized attribute. - Took out unnecessary "register_buffer" calls (this happens automatically with `torch.nn.Module.setattr`) Differential Revision: D41172490 fbshipit-source-id: c6e26914be9b25ba268de3355a1ddc8ee9fb66d0
esantorella
force-pushed
the
export-D41172490
branch
from
17cc28a to
b8f5d26
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41172490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
compute_hypervolumeso that each BoxDecomposition subclass uses shared logic for the no-data caseYisNone, functions of Y likebox_decomp._neg_YareNonerather than being unset attributes, so we do "if self._neg_Y is None" rather than catching an AttributeError. This makes catching type errors easier since otherwise Pyre is unhappy about references to the potentially-uninitialized attribute.torch.nn.Module.setattr)Differential Revision: D41172490