Follow-ups from D40783106 (fantasize refactor) #1479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41053234 |
Codecov Report
@@ Coverage Diff @@
## main #1479 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 134 134
Lines 12397 12408 +11
=========================================
+ Hits 12397 12408 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Nov 7, 2022
Summary: see T137147547 Remove inappropriate subclassing of `SingleTaskGP` (and clean up associated to-dos) [x] Make `HeteroskedasticSingleTaskGP` not a subclass of `SingleTaskGP` since it can't `fantasize` [x] Make `SaasFullyBayesianSingleTaskGP` not a subclass of `SingleTaskGP` since it can't `fantasize` [x] Fix downstream problems in multiple dispatched this caused.... Add `fantasize` back to classes that weren't using it, but can call it and used to have it [x] Make `MultiTaskGP` have a `fantasize` method (debatable! it used to have one, but wasn't used) [x] Restore `fantasize` method with `NotImplementedError` to `SaasFullyBayesianMultiTaskGP` (as a result of adding `fantasize` to `MultiTaskGP`) [x] Make `KroneckerMultiTaskGP` have a `fantasize` method (debatable! it used to have one, but wasn't used) Pull Request resolved: pytorch#1479 Differential Revision: D41053234 Pulled By: esantorella fbshipit-source-id: 6f422916b7ae20fe8235b280e4b917055cfab5d1
esantorella
force-pushed
the
export-D41053234
branch
from
1a5d04e to
dd54803
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41053234 |
Summary: see T137147547 Remove inappropriate subclassing of `SingleTaskGP` (and clean up associated to-dos) [x] Make `HeteroskedasticSingleTaskGP` not a subclass of `SingleTaskGP` since it can't `fantasize` [x] Make `SaasFullyBayesianSingleTaskGP` not a subclass of `SingleTaskGP` since it can't `fantasize` [x] Fix downstream problems in multiple dispatched this caused.... Add `fantasize` back to classes that weren't using it, but can call it and used to have it [x] Make `MultiTaskGP` have a `fantasize` method (debatable! it used to have one, but wasn't used) [x] Restore `fantasize` method with `NotImplementedError` to `SaasFullyBayesianMultiTaskGP` (as a result of adding `fantasize` to `MultiTaskGP`) [x] Make `KroneckerMultiTaskGP` have a `fantasize` method (debatable! it used to have one, but wasn't used) Pull Request resolved: pytorch#1479 Reviewed By: saitcakmak Differential Revision: D41053234 Pulled By: esantorella fbshipit-source-id: 2616ec741cf93504c8e709002cb0de88d69f3adb
esantorella
force-pushed
the
export-D41053234
branch
from
dd54803 to
41c4f90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41053234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
see T137147547
[x] Make
HeteroskedasticSingleTaskGPnot a subclass ofSingleTaskGPsince it can'tfantasize[x] Make
SaasFullyBayesianSingleTaskGPnot a subclass ofSingleTaskGPsince it can'tfantasize[x] Make
MultiTaskGPhave afantasizemethod (debatable! it used to have one, but wasn't used)[x] Restore
fantasizemethod withNotImplementedErrortoSaasFullyBayesianMultiTaskGP(as a result of addingfantasizetoMultiTaskGP)[x] Make
KroneckerMultiTaskGPhave afantasizemethod (debatable! it used to have one, but wasn't used)[x] Clean up some especially annoying type errors so I can use Pyre for my own use
Differential Revision: D41053234