Don't use Pyro jit by default #1474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We have observed that using jit with Pyro can result in increased memory usage and even memory leaks, so we are disabling it for now. This will make model fitting with NUTS about ~2X slower. Reviewed By: esantorella Differential Revision: D40949763 fbshipit-source-id: baeee02cd6358ffabb984920da865c780300cc1f
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40949763 |
Codecov Report
@@ Coverage Diff @@
## main #1474 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 134 134
Lines 12397 12397
=========================================
Hits 12397 12397
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Nov 3, 2022
Summary: X-link: pytorch/botorch#1474 Pull Request resolved: #1241 We have observed that using jit with Pyro can result in increased memory usage and even memory leaks, so we are disabling it for now. This will make model fitting with NUTS about ~2X slower. Reviewed By: esantorella Differential Revision: D40949763 fbshipit-source-id: a5c6dc772c3000d4ee788a541fe2f7009fe3aafa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We have observed that using jit with Pyro can result in increased memory usage and even memory leaks, so we are disabling it for now. This will make model fitting with NUTS about ~2X slower.
Reviewed By: esantorella
Differential Revision: D40949763