Fix input transform bug when sequentially training a BatchedMultiOutputModel
#1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40453200 |
…putModel` (pytorch#1454) Summary: Pull Request resolved: pytorch#1454 This fixes a bug where, due to the input transform being in `train` mode while the model is in `eval` mode, the learnable bounds of input transforms, such as Normalize, would be wrongly updated during model training, effectively disabling the transforms. This is a serious bug that was leading to using the model trained with normalized inputs on a model without any normalization. It has been around for a while, since pytorch#1283 :'(. Differential Revision: D40453200 fbshipit-source-id: 0d60ac5f23efe06e200713555dfa109b612d9290
saitcakmak
force-pushed
the
export-D40453200
branch
from
4abe93b to
a400481
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40453200 |
AdrianSosic
pushed a commit
to emdgroup/baybe
that referenced
this pull request
Nov 28, 2023
This PR cleans up the code dependencies: * Bumps `botorch` to version 0.8.1 in order to fix a critical bug (pytorch/botorch#1454) that has been around until version 0.7.3 * Pins all code formatting related package versions to prevent unexpected formatting changes (see ufmt installation guide for details) * Marks some as dev-dependencies Related work items: #9360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes a bug where, due to the input transform being in
trainmode while the model is inevalmode, the learnable bounds of input transforms, such as Normalize, would be wrongly updated during model training, effectively disabling the transforms.This is a serious bug that was leading to using the model trained with normalized inputs on a model without any normalization. It has been around for a while, since #1283 :'(.
Differential Revision: D40453200