fix bug in model list with output indices #1453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Calling forward directly, bypasses logic in __call__ for the submodels. The resulting posterior is incorrect (the new tests fail without the change). Differential Revision: D40436652 fbshipit-source-id: 942652f14381ae706535bad207c67a7708eb40fa
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40436652 |
Codecov Report
@@ Coverage Diff @@
## main #1453 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 124 124
Lines 11548 11548
=========================================
Hits 11548 11548
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Calling forward directly, bypasses logic in call for the submodels. The resulting posterior is incorrect (the new tests fail without the change).
Differential Revision: D40436652