Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle RuntimeError due to constraint violation while sampling from priors #1451

Closed
wants to merge 1 commit into from

Conversation

danielrjiang
Copy link
Contributor

Summary:
On fitting retries, sometimes sampling from the prior will violate a parameter constraint, leading an error like

RuntimeError: Attempting to manually set a parameter value that is out of bounds of its current constraints...

Reviewed By: dme65, saitcakmak

Differential Revision: D40272361

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Oct 13, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40272361

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #1451 (990d2a1) into main (093668e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 990d2a1 differs from pull request most recent head 91cf955. Consider uploading reports for the commit 91cf955 to get more accurate results

@@            Coverage Diff            @@
##              main     #1451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          124       124           
  Lines        11540     11548    +8     
=========================================
+ Hits         11540     11548    +8     
Impacted Files Coverage Δ
botorch/optim/utils.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…riors (pytorch#1451)

Summary:
Pull Request resolved: pytorch#1451

On fitting retries, sometimes sampling from the prior will violate a parameter constraint, leading an error like
> RuntimeError: Attempting to manually set a parameter value that is out of bounds of its current constraints...

Reviewed By: dme65, saitcakmak

Differential Revision: D40272361

fbshipit-source-id: 205a8e8d7f66d73e3eaa2453feb39033b69513d5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40272361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants