Fix matplotlib error in BOPE tutorial #1446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40232488 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 10, 2022
Summary: Pull Request resolved: pytorch#1446 Matplotlib 3.6.1 has a bug with NaN handling (matplotlib/matplotlib#24127), leading to errors when running the tutorial. This implements a workaround, replacing `yerr` with NaNs with `None`. Differential Revision: D40232488 fbshipit-source-id: ccb8dab6d3d8b3798bfbc7aaf5e3f1f1390bfd9d
saitcakmak
force-pushed
the
export-D40232488
branch
from
1591dae to
696677e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40232488 |
Codecov Report
@@ Coverage Diff @@
## main #1446 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 124 124
Lines 11529 11533 +4
=========================================
+ Hits 11529 11533 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Also, is there a reason to switch |
|
Good catch. I must've used an older version of the notebook, will fix. |
Summary: Pull Request resolved: pytorch#1446 Matplotlib 3.6.1 has a bug with NaN handling (matplotlib/matplotlib#24127), leading to errors when running the tutorial. This implements a workaround, replacing `yerr` with NaNs with `None`. Differential Revision: D40232488 fbshipit-source-id: a80a31c42ea4426638dcf864731c72e554729c00
saitcakmak
force-pushed
the
export-D40232488
branch
from
696677e to
7161188
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40232488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Matplotlib 3.6.1 has a bug with NaN handling (matplotlib/matplotlib#24127), leading to errors when running the tutorial. This implements a workaround, replacing
yerrwith NaNs withNone.Differential Revision: D40232488