Fix batch_shape property of ModelListGPyTorchModel #1441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously, this was assuming the submodel batch shape is same as the input batch shape, which is not true for SAAS models. With this update, the batch shape correctly reflects the batch shape of the underlying models. Differential Revision: D40165810 fbshipit-source-id: d69f961182421211a0fc88b7d537ccf8911250b7
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40165810 |
Codecov Report
@@ Coverage Diff @@
## main #1441 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 124 124
Lines 11529 11529
=========================================
Hits 11529 11529
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously, this was assuming the submodel batch shape is same as the input batch shape, which is not true for SAAS models. With this update, the batch shape correctly reflects the batch shape of the underlying models.
Differential Revision: D40165810