Explicitly install multipledispatch for conda build in nightly cron #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, imports are failing due to multipledispatch not being installed.
facebook-github-bot
added
the
CLA Signed
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #1421 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 124 124
Lines 11533 11533
=========================================
Hits 11533 11533 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
saitcakmak
approved these changes
Sep 26, 2022
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Sep 27, 2022
The changes from pytorch#1421 did not make it into the auto-deployment workflow. This fixes the issue allowing the conda package build and upload to be successful. Also removes an unnecessary pin of jinja2.
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 28, 2022
Summary: The changes from #1421 did not make it into the auto-deployment workflow. This fixes the issue allowing the conda package build and upload to be successful. Also removes an unnecessary pin of jinja2. Pull Request resolved: #1427 Reviewed By: esantorella Differential Revision: D39860235 Pulled By: esantorella fbshipit-source-id: ac60f52aec76f4f1c533929dd2ed45e7d3e5dcfb
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 14, 2023
…h#1421) Summary: X-link: facebook/Ax#1421 Pull Request resolved: pytorch#1677 The previous diff discusses issues with kwargs in BoTorch optimizers and resolves some of them. This diff warns if keyword arguments that do nothing are passed to an optimizer, and stops Ax (botorch-modular) from doing that. Reviewed By: lena-kashtelyan Differential Revision: D43277102 fbshipit-source-id: f22b4cd1c4b6227a5210f27d1501c3667209a1d7
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
Summary: X-link: facebook/Ax#1421 Pull Request resolved: #1677 The previous diff discusses issues with kwargs in BoTorch optimizers and resolves some of them. This diff warns if keyword arguments that do nothing are passed to an optimizer, and stops Ax (botorch-modular) from doing that. Reviewed By: lena-kashtelyan Differential Revision: D43277102 fbshipit-source-id: b31ef580223fd9d8596a9c69ac4035cbd9e8f3ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, imports are failing due to
multipledispatchnot being installed.