Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing model_list_to_batched ignoring the covar_module of the input models #1419

Closed
wants to merge 3 commits into from

Conversation

SebastianAment
Copy link
Contributor

Summary: This diff fixes the bug reported here.

Differential Revision: D39781851

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Sep 23, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39781851

…ut models (pytorch#1419)

Summary:
Pull Request resolved: pytorch#1419

This diff fixes the bug reported [here](pytorch#1411).

Differential Revision: D39781851

fbshipit-source-id: 99b1c2e0c16f66861381a261a997d98c765f707a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39781851

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #1419 (656155c) into main (15f23cc) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 656155c differs from pull request most recent head 5d6cf19. Consider uploading reports for the commit 5d6cf19 to get more accurate results

@@            Coverage Diff            @@
##              main     #1419   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          124       124           
  Lines        11533     11554   +21     
=========================================
+ Hits         11533     11554   +21     
Impacted Files Coverage Δ
botorch/models/converter.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants