Removing custom BlockDiagLazyTensor logic when using Standardize (Take 2)
#1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39746709 |
Codecov Report
@@ Coverage Diff @@
## main #1414 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 134 134
Lines 12408 12403 -5
=========================================
- Hits 12408 12403 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request was exported from Phabricator. Differential Revision: D39746709 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Nov 7, 2022
…(Take 2) (pytorch#1414) Summary: Pull Request resolved: pytorch#1414 Due to [this linear operator PR](cornellius-gp/linear_operator#14), we should now be able to remove the custom logic in `Standardize` without performance impact. Differential Revision: D39746709 fbshipit-source-id: 506d1fc3a34778fa5bb0d91779ca5f73b24f4146
SebastianAment
force-pushed
the
export-D39746709
branch
from
b1460d7 to
893b763
Compare
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Nov 8, 2022
…(Take 2) (pytorch#1414) Summary: Pull Request resolved: pytorch#1414 Due to [this linear operator PR](cornellius-gp/linear_operator#14), we should now be able to remove the custom logic in `Standardize` without performance impact. Differential Revision: D39746709 fbshipit-source-id: 1c68d8033d18c4a489600dd743ad5ab24efc5fb0
SebastianAment
force-pushed
the
export-D39746709
branch
from
893b763 to
045e22c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39746709 |
…(Take 2) (pytorch#1414) Summary: Pull Request resolved: pytorch#1414 Due to [this linear operator PR](cornellius-gp/linear_operator#14), we should now be able to remove the custom logic in `Standardize` without performance impact. Reviewed By: saitcakmak Differential Revision: D39746709 fbshipit-source-id: c1477bcc14ec145583a5d0501fbe1cdac5bfe9bd
SebastianAment
force-pushed
the
export-D39746709
branch
from
045e22c to
d9fabef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39746709 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 10, 2023
…ytorch#1414) Summary: Pull Request resolved: facebook/Ax#1414 Differential Revision: D43178298 fbshipit-source-id: 05441f9140d7971439ed931d66e78a9cb0d9aebf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Due to this linear operator PR, we should now be able to remove the custom logic in
Standardizewithout performance impact.Differential Revision: D39746709