Improving test coverage of UnifiedSkewNormal code #1408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
Codecov Report
@@ Coverage Diff @@
## main #1408 +/- ##
========================================
Coverage 99.98% 99.98%
========================================
Files 124 134 +10
Lines 11554 12382 +828
========================================
+ Hits 11552 12380 +828
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Sep 23, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 7268c7f623a16ae2b2fe33d6a55a12d2aee9ca7e
SebastianAment
force-pushed
the
export-D39556258
branch
from
3358dd2 to
5427548
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Sep 26, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: f2ff5bf5bf564e07a006e241ff963222874d8d5d
SebastianAment
force-pushed
the
export-D39556258
branch
from
5427548 to
ed37d61
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Sep 26, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 4f3b956db52641b34d96642287c42982bdfdfe5f
SebastianAment
force-pushed
the
export-D39556258
branch
from
ed37d61 to
81393bf
Compare
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Sep 26, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 33e4371e37152c588132dd512c99f6b857d9caf2
SebastianAment
force-pushed
the
export-D39556258
branch
from
81393bf to
6171160
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Sep 26, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 83206e5a142c92841a036695acd859e51f7e74be
SebastianAment
force-pushed
the
export-D39556258
branch
from
6171160 to
b532df0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Sep 27, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: f08c95f727f7ccffee7642dc88614289070485c3
SebastianAment
force-pushed
the
export-D39556258
branch
from
b532df0 to
07cdf16
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Sep 27, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 470cf3f5fc4f8004f7b65b33fd9e570ec927fc74
SebastianAment
force-pushed
the
export-D39556258
branch
from
07cdf16 to
3e2e0eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Sep 27, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 8441b859fcb67c5449e80f5815397dfda598feb7
SebastianAment
force-pushed
the
export-D39556258
branch
from
3e2e0eb to
8b106cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Sep 27, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: f38802425a357ab5b653e7bd45c8ead5c0343b35
SebastianAment
force-pushed
the
export-D39556258
branch
from
8b106cb to
dd17691
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Oct 6, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: e62016ce08764fc669d158da6a64dc6bfcdc5fc2
SebastianAment
force-pushed
the
export-D39556258
branch
from
fac2581 to
fce4ffa
Compare
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Oct 6, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 4e012054abf4ece1f1739dfc13eb051f09be828d
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
force-pushed
the
export-D39556258
branch
from
fce4ffa to
16d0bde
Compare
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Oct 17, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 27b5afc3560864fc50627e0f767387de108e895a
SebastianAment
force-pushed
the
export-D39556258
branch
from
8f17b1f to
1f27cad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Oct 17, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 197c070f8b10abfc9a6bf7cb7873352b2edf48bd
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
force-pushed
the
export-D39556258
branch
from
1f27cad to
0defce3
Compare
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Oct 17, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Differential Revision: D39556258 fbshipit-source-id: 9c27f49db2503ad0451cbdd7b90937349e334a9d
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
force-pushed
the
export-D39556258
branch
from
0defce3 to
497407c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Oct 18, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Reviewed By: j-wilson Differential Revision: D39556258 fbshipit-source-id: 96b62bf97254e7f54ba1089350f679cbf4ab4bda
SebastianAment
force-pushed
the
export-D39556258
branch
from
5544b84 to
b129a31
Compare
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Oct 19, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Reviewed By: j-wilson Differential Revision: D39556258 fbshipit-source-id: 0dbe542ea2013d56507096f18216fde82889d574
SebastianAment
force-pushed
the
export-D39556258
branch
from
b129a31 to
13c7751
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Oct 19, 2022
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Reviewed By: j-wilson Differential Revision: D39556258 fbshipit-source-id: a64f18cf56efbe706ba45ff0293b6aec9375ad07
SebastianAment
force-pushed
the
export-D39556258
branch
from
13c7751 to
9d2e513
Compare
…rch#1394) Summary: Pull Request resolved: pytorch#1394 Introduces `utils/probability` submodule with the following offers: - `bvn`: Methods for computing bivariate normal probabilities and moments. - `MVNXPB`: Approximate solver for Multivariate Normal CDF. - `LinearEllipticalSliceSampler`: Class for sampling trMVN random variables. - `TruncatedMultivariateNormal`: Truncated multivariate normal Distribution class - `UnifiedSkewNormal`: Unified skew normal Distribution class Reviewed By: Balandat Differential Revision: D39326106 fbshipit-source-id: d4f3346355ee9fc6312e04dfe17f0ae0427dbf2c
Summary: Pull Request resolved: pytorch#1408 This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, [see here](https://app.codecov.io/gh/pytorch/botorch/pull/1394). Reviewed By: j-wilson Differential Revision: D39556258 fbshipit-source-id: 07780fbb0902e82ca8cf06b3edda629f0ea9d1dd
|
This pull request was exported from Phabricator. Differential Revision: D39556258 |
SebastianAment
force-pushed
the
export-D39556258
branch
from
9d2e513 to
6ef20f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit improves the test coverage of the code located in botorch/utils/probability. For the current coverage without this commit, see here.
Differential Revision: D39556258