Add SMOKE_TEST option to MOMF tutorial #1243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This currently times out and fails the smoketest tutorial runs. Differential Revision: D36911899 fbshipit-source-id: 16a80d41c219177c4e8a5c6b78e32ee732fcdfc3
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D36911899 |
Codecov Report
@@ Coverage Diff @@
## main #1243 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 122 122
Lines 10576 10576
=========================================
Hits 10576 10576 Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
Summary: X-link: facebook/Ax#1243 Pull Request resolved: #1475 A few tutorials were not compatible with the new way we fetch data. In this diff we change custom metrics to return Ok(data) instead of data, and change `trial.fetch_data()` => `Metric._unwrap_trial_data_multi(results=trial.fetch_data())`. In the future we may want to add some copy in the tutorials discussing Result, but we should land this for now to get things working again ASAP Reviewed By: dme65 Differential Revision: D40994060 fbshipit-source-id: 9a5f86273a7da8496e480a0d7ca0aa2c03ecb194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This currently times out and fails the smoketest tutorial runs.
Differential Revision: D36911899