Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump coverage to 100% #1234

Closed
wants to merge 1 commit into from
Closed

Conversation

Balandat
Copy link
Contributor

#1233 missed a line, this adds test coverage for that

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 28, 2022
@facebook-github-bot
Copy link
Contributor

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #1234 (aa14b52) into main (e736a8a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main     #1234   +/-   ##
========================================
  Coverage   99.99%   100.00%           
========================================
  Files         122       122           
  Lines       10562     10562           
========================================
+ Hits        10561     10562    +1     
+ Misses          1         0    -1     
Impacted Files Coverage Δ
botorch/acquisition/fixed_feature.py 100.00% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e736a8a...aa14b52. Read the comment docs.

@Balandat Balandat deleted the fix_fixed_feat_coverage branch May 28, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants