-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --op-collection option #2503
base: main
Are you sure you want to change the base?
Conversation
torchbenchmark/operators/__init__.py
Outdated
@@ -40,8 +59,16 @@ def _list_opbench_paths() -> List[str]: | |||
return opbench | |||
|
|||
|
|||
def list_operators() -> List[str]: | |||
def list_operators(op_collection: OP_COLLECTION = OP_COLLECTION.DEFAULT) -> List[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuzhao9 maybe we should use List(str)
as the argument?
I am thinking we should have a clearer place to manage operator collection. Can we create a new directory |
updated in 5e1e7b1 |
This PR add
--op-collection
to tritonbench. It can run multiple ops in defined operator collections. The default collection includes all ops not included in other collections.Operator collections are defined in
torchbenchmark/operators_collection/
. For each collection, you should define aget_operators
function to return operators included in this collection.