Disable llama_v2_7b_16h on optim benchmarks as they currently OOM #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
reviewed
Jul 28, 2023
| super().__init__(name="llama_v2_7b_8h", test=test, device=device, batch_size=batch_size, extra_args=extra_args) | ||
|
|
||
| def train(self): | ||
| return NotImplementedError("7b LLAMA model will OOM on CI GPU machines") |
There was a problem hiding this comment.
Currently our criteria to accept model is that the eager mode test does not OOM on CI GPU machines (A10G and A100, respectively). We cannot guarantee that they won't OOM on the optim userbenchmark.
There was a problem hiding this comment.
Yea, this makes sense to me, which is why this required more of a review. I think the right course of action then is to disable llama_v2_7b_16h on optim benchmarks until train is supported.
janeyx99
changed the title
janeyx99
force-pushed
the
add-llama_v2_7b_8h
branch
from
dc9a444
to
4f19a13
Compare
|
@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1791
Test plan:
https://github.com/pytorch/benchmark/actions/runs/5693564120 a run of the optim benchmarks