Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply 'nightly' branch filter to binary uploads #385

Merged
merged 1 commit into from
Jan 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,9 @@ workflows:
python_version: '3.5'
- binary_wheel_upload:
context: org-member
filters:
branches:
only: nightly
name: nightly_binary_linux_wheel_py3.5_upload
requires:
- nightly_binary_linux_wheel_py3.5
Expand All @@ -343,6 +346,9 @@ workflows:
python_version: '3.6'
- binary_wheel_upload:
context: org-member
filters:
branches:
only: nightly
name: nightly_binary_linux_wheel_py3.6_upload
requires:
- nightly_binary_linux_wheel_py3.6
Expand All @@ -362,6 +368,9 @@ workflows:
python_version: '3.7'
- binary_wheel_upload:
context: org-member
filters:
branches:
only: nightly
name: nightly_binary_linux_wheel_py3.7_upload
requires:
- nightly_binary_linux_wheel_py3.7
Expand Down Expand Up @@ -466,6 +475,9 @@ workflows:
python_version: '3.5'
- binary_conda_upload:
context: org-member
filters:
branches:
only: nightly
name: nightly_binary_linux_conda_py3.5_upload
requires:
- nightly_binary_linux_conda_py3.5
Expand All @@ -485,6 +497,9 @@ workflows:
python_version: '3.6'
- binary_conda_upload:
context: org-member
filters:
branches:
only: nightly
name: nightly_binary_linux_conda_py3.6_upload
requires:
- nightly_binary_linux_conda_py3.6
Expand All @@ -504,6 +519,9 @@ workflows:
python_version: '3.7'
- binary_conda_upload:
context: org-member
filters:
branches:
only: nightly
name: nightly_binary_linux_conda_py3.7_upload
requires:
- nightly_binary_linux_conda_py3.7
Expand Down
5 changes: 1 addition & 4 deletions .circleci/regenerate.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,7 @@ def workflow_pair(btype, os_type, python_version, unicode, filter_branch, prefix

is_py3_linux = os_type == 'linux' and not python_version.startswith("2.")

# XXX This logic is suspect...
upload_job_filter_branch = not is_py3_linux and filter_branch

w.append(generate_upload_workflow(base_workflow_name, upload_job_filter_branch, btype))
w.append(generate_upload_workflow(base_workflow_name, filter_branch, btype))

if filter_branch == 'nightly' and is_py3_linux:
pydistro = 'pip' if btype == 'wheel' else 'conda'
Expand Down