Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move autoround from generate.py to eval.py #868

Merged
merged 8 commits into from
Sep 14, 2024

Conversation

yiliu30
Copy link
Contributor

@yiliu30 yiliu30 commented Sep 11, 2024

As Auto-Round is an algorithm focused on improving accuracy instead of perf, move it from generate.py to eval.py.

cc @thuang6

Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Copy link

pytorch-bot bot commented Sep 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/868

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 77889a1 with merge base b4d0768 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2024
@yiliu30
Copy link
Contributor Author

yiliu30 commented Sep 11, 2024

Hi @HDCharles @jerryzh168, please have a look, thanks!

Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Copy link
Contributor

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

@yiliu30 yiliu30 mentioned this pull request Sep 13, 2024
1 task
@yiliu30
Copy link
Contributor Author

yiliu30 commented Sep 13, 2024

Ready to merge.

@HDCharles HDCharles merged commit d2bce6a into pytorch:main Sep 14, 2024
17 checks passed
jainapurva pushed a commit that referenced this pull request Sep 22, 2024
* move autoround from generate to eval

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* add llama3 back

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* update the scripts

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* update the scripts

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* rename eval_acc.sh -> evals.sh

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* update

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* update

Signed-off-by: yiliu30 <yi4.liu@intel.com>

---------

Signed-off-by: yiliu30 <yi4.liu@intel.com>
jainapurva pushed a commit that referenced this pull request Sep 23, 2024
* move autoround from generate to eval

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* add llama3 back

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* update the scripts

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* update the scripts

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* rename eval_acc.sh -> evals.sh

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* update

Signed-off-by: yiliu30 <yi4.liu@intel.com>

* update

Signed-off-by: yiliu30 <yi4.liu@intel.com>

---------

Signed-off-by: yiliu30 <yi4.liu@intel.com>
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
llama.cpp did a BC breaking refactor: ggerganov/llama.cpp@1c641e6
resulting in some of our CI breaking

This updates our CI to match llama.cpp's schema
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* Initial Creation of a quantization directory

* Moving qops

* updating import

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Update Quant call using llama.cpp (pytorch#868)

llama.cpp did a BC breaking refactor: ggerganov/llama.cpp@1c641e6
resulting in some of our CI breaking

This updates our CI to match llama.cpp's schema

* Updating torch nightly to pick up aoti improvements in 128339 (pytorch#862)

* Updating torch nightly to pick up aoti improvements in 128339

* Update the torch version to 2.5

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* Removing all references to HQQ

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Update Quant call using llama.cpp (pytorch#868)

llama.cpp did a BC breaking refactor: ggerganov/llama.cpp@1c641e6
resulting in some of our CI breaking

This updates our CI to match llama.cpp's schema

* Updating torch nightly to pick up aoti improvements in 128339 (pytorch#862)

* Updating torch nightly to pick up aoti improvements in 128339

* Update the torch version to 2.5

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Creating an initial Quantization Directory (pytorch#863)

* Initial Creation of a quantization directory

* Moving qops

* updating import

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Update Quant call using llama.cpp (pytorch#868)

llama.cpp did a BC breaking refactor: ggerganov/llama.cpp@1c641e6
resulting in some of our CI breaking

This updates our CI to match llama.cpp's schema

* Updating torch nightly to pick up aoti improvements in 128339 (pytorch#862)

* Updating torch nightly to pick up aoti improvements in 128339

* Update the torch version to 2.5

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* Removing GPTQ from all of torchchat

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Rebase + Add back accidental deletion

* Update Quant call using llama.cpp (pytorch#868)

llama.cpp did a BC breaking refactor: ggerganov/llama.cpp@1c641e6
resulting in some of our CI breaking

This updates our CI to match llama.cpp's schema

* Updating torch nightly to pick up aoti improvements in 128339 (pytorch#862)

* Updating torch nightly to pick up aoti improvements in 128339

* Update the torch version to 2.5

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Creating an initial Quantization Directory (pytorch#863)

* Initial Creation of a quantization directory

* Moving qops

* updating import

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Update Quant call using llama.cpp (pytorch#868)

llama.cpp did a BC breaking refactor: ggerganov/llama.cpp@1c641e6
resulting in some of our CI breaking

This updates our CI to match llama.cpp's schema

* Updating torch nightly to pick up aoti improvements in 128339 (pytorch#862)

* Updating torch nightly to pick up aoti improvements in 128339

* Update the torch version to 2.5

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Removing all references to HQQ (pytorch#869)

* Removing all references to HQQ

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Update Quant call using llama.cpp (pytorch#868)

llama.cpp did a BC breaking refactor: ggerganov/llama.cpp@1c641e6
resulting in some of our CI breaking

This updates our CI to match llama.cpp's schema

* Updating torch nightly to pick up aoti improvements in 128339 (pytorch#862)

* Updating torch nightly to pick up aoti improvements in 128339

* Update the torch version to 2.5

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Creating an initial Quantization Directory (pytorch#863)

* Initial Creation of a quantization directory

* Moving qops

* updating import

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)

* Update Quant call using llama.cpp (pytorch#868)

llama.cpp did a BC breaking refactor: ggerganov/llama.cpp@1c641e6
resulting in some of our CI breaking

This updates our CI to match llama.cpp's schema

* Updating torch nightly to pick up aoti improvements in 128339 (pytorch#862)

* Updating torch nightly to pick up aoti improvements in 128339

* Update the torch version to 2.5

* Updating lm_eval version (pytorch#865)

Fixing CI related to EleutherAI/wikitext_document_level change requirements from using HF Datasets

* Pinning numpy to under 2.0 (pytorch#867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants