Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move autoround from generate.py to eval.py #868

Merged
merged 8 commits into from
Sep 14, 2024
Merged

Move autoround from generate.py to eval.py #868

merged 8 commits into from
Sep 14, 2024

Conversation

yiliu30
Copy link
Contributor

@yiliu30 yiliu30 commented Sep 11, 2024

As Auto-Round is an algorithm focused on improving accuracy instead of perf, move it from generate.py to eval.py.

cc @thuang6

@yiliu30
move autoround from generate to eval
efe1844 
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@yiliu30
add llama3 back
6636637 
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/868

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 77889a1 with merge base b4d0768 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2024
@yiliu30
Copy link
Contributor Author

yiliu30 commented Sep 11, 2024

Hi @HDCharles @jerryzh168, please have a look, thanks!

@yiliu30
update the scripts
2e21cab 
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@yiliu30
update the scripts
aecb775 
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@yiliu30
rename eval_acc.sh -> evals.sh
4b8cdd1 
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@yiliu30
resolve conflicts
3a22a0b 
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@yiliu30
update
d9580e3 
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@yiliu30
update
77889a1 
Signed-off-by: yiliu30 <yi4.liu@intel.com>
HDCharles
HDCharles approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

@yiliu30 yiliu30 mentioned this pull request Sep 13, 2024
Merged
1 task
@yiliu30
Copy link
Contributor Author

yiliu30 commented Sep 13, 2024 •
edited
Loading

Ready to merge.

@HDCharles HDCharles merged commit d2bce6a into pytorch:main Sep 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@HDCharles HDCharles HDCharles approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiliu30 @jerryzh168 @HDCharles @facebook-github-bot