Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Float8] Fix serialization of dynamic activation fp8 #838

Closed
wants to merge 2 commits into from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Sep 6, 2024

Copy link

pytorch-bot bot commented Sep 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/838

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3f56940 with merge base 65d86c6 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

drisspg added a commit that referenced this pull request Sep 6, 2024
stack-info: PR: #838, branch: drisspg/stack/12
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2024
@drisspg drisspg requested a review from jerryzh168 September 6, 2024 23:24
@drisspg drisspg changed the base branch from drisspg/stack/11 to main September 6, 2024 23:57
drisspg added a commit that referenced this pull request Sep 6, 2024
stack-info: PR: #838, branch: drisspg/stack/12
@drisspg drisspg changed the base branch from main to drisspg/stack/11 September 6, 2024 23:57
@jerryzh168
Copy link
Contributor

this PR seems to contain all the changes from the previous PR?

@drisspg drisspg changed the base branch from drisspg/stack/11 to main September 7, 2024 01:03
drisspg added a commit that referenced this pull request Sep 7, 2024
stack-info: PR: #838, branch: drisspg/stack/12
@drisspg drisspg changed the base branch from main to drisspg/stack/11 September 7, 2024 01:03
stack-info: PR: #838, branch: drisspg/stack/12
@drisspg drisspg changed the base branch from drisspg/stack/11 to main September 7, 2024 01:05
@drisspg drisspg changed the base branch from main to drisspg/stack/11 September 7, 2024 01:05
@drisspg drisspg force-pushed the drisspg/stack/11 branch 2 times, most recently from eae3b8f to 0405f9e Compare September 7, 2024 01:10
@drisspg drisspg removed the request for review from jerryzh168 September 7, 2024 01:10
@drisspg drisspg closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants