Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2, 3, 4, 5 bit custom ops #828

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

metascroy
Copy link
Contributor

Summary: Refactors some of the custom op example code to add support for more kernel variants.

Reviewed By: digantdesai

Differential Revision: D62248716

Copy link

pytorch-bot bot commented Sep 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/828

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0fd7957 with merge base e1039ab (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2024
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D62248716

m = 1
n = 4096
k = 4096
nbit = 4
n_layers = 10
nbit = 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering is this uint5 or int5?

Copy link
Contributor Author

@metascroy metascroy Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 5bit kernel has quantized range [-16, 15].

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D62248716

metascroy added a commit to metascroy/ao that referenced this pull request Sep 9, 2024
Summary:
Pull Request resolved: pytorch#828

Refactors some of the custom op example code to add support for more kernel variants.

Reviewed By: digantdesai

Differential Revision: D62248716
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D62248716

metascroy added a commit to metascroy/ao that referenced this pull request Sep 9, 2024
Summary:
Pull Request resolved: pytorch#828

Refactors some of the custom op example code to add support for more kernel variants.

Reviewed By: digantdesai

Differential Revision: D62248716
Summary:
Pull Request resolved: pytorch#828

Refactors some of the custom op example code to add support for more kernel variants.

Reviewed By: digantdesai

Differential Revision: D62248716
@facebook-github-bot facebook-github-bot merged commit 9d169a8 into pytorch:main Sep 9, 2024
17 of 19 checks passed
jainapurva pushed a commit that referenced this pull request Sep 9, 2024
Differential Revision: D62248716

Pull Request resolved: #828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants