-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i will merge] Upgrade python version to 3.9 #488
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/488
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7e2c6bc with merge base 12ac498 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
FYI @ebsmothers for now just decided to drop 3.8, I think we will end up being conservating with upgrading python versions but will revisit with the rest of the ao team if this ends up being a controversial decisision |
* push * Upgrade to python 3.11 * push * push * push * Update README.md * Update regression_test.yml
Fixes pytorch/torchchat#468 and pytorch/torchchat#466. Updates named arguments to be registered on subparsers, which allows removal of the arg re-ordering code.
We're trying to upgrade from 3.8 to a more modern Python version to use some newer features like
3.8 is reaching EOL imminently so we must upgrade to at least 3.9 https://devguide.python.org/versions/
If we were to do what PyTorch does we'd simply upgrade to 3.9 and try to avoid using 3.10+ features pytorch/rfcs#65
Upgrading to 3.9
This also works and is probably the least controversial thing to merge
Upgrading to 3.10
This just works, CI is green so we can merge this PR as is
Upgrading to 3.11
This made the dora optimizer crash - cc @jeromeku in case you're interested