Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HF_TOKEN env variable #427

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Update HF_TOKEN env variable #427

merged 3 commits into from
Jul 9, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Jun 24, 2024

The old env variable was deprecated in favor of HF_TOKEN so this is a mundane change https://huggingface.co/docs/huggingface_hub/en/package_reference/environment_variables

@HDCharles I've heard you mention that downloading weights in CI didn't work with AO in the past so let me know which specific test you'd like to see pass

Copy link

pytorch-bot bot commented Jun 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/427

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fe26191 with merge base ab4ec43 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2024
@msaroufim msaroufim requested a review from jerryzh168 July 9, 2024 01:19
@jerryzh168 jerryzh168 merged commit a618596 into main Jul 9, 2024
13 checks passed
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
* Update HF_TOKEN env variable

* Update nightly_smoke_test.yml
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* [torchchat] persistent history in chat

* remove some prints

* add system prompt

* use gh ci to debug

* more ci testing

* more ci testing

* uncomment tests

* add kwarg to generate

* chat works for llama3

* fix case where max-new-tokens is hit for llama3

* remove time added by accident in merge conflict

* remove llama3 detection from cli and piggy back off tokenizer instead

* remove more llama3 flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants