Minor fix on TAO op to support lowering #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from RandySheriff:export-D82492826

Sep 22, 2025

Contributor

RandySheriff commented Sep 18, 2025

Summary: Fix a few functionality gaps to let TAO operator works during AOTI lowering ~

Differential Revision: D82492826

pytorch-bot bot commented Sep 18, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3031

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

B200 runners offline

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Sep 18, 2025

@RandySheriff has exported this pull request. If you are a Meta employee, you can view the originating diff in D82492826.

facebook-github-bot added fb-exported meta-exported labels

RandySheriff added a commit to RandySheriff/ao that referenced this pull request


          Minor fix on TAO op to support lowering (pytorch#3031)

f413701

Summary:

Fix a few functionality gaps to let TAO operator works during AOTI lowering ~

Differential Revision: D82492826

RandySheriff force-pushed the export-D82492826 branch from c862f80 to f413701 Compare

September 18, 2025 19:16

Contributor

facebook-github-bot commented Sep 18, 2025

@RandySheriff has exported this pull request. If you are a Meta employee, you can view the originating diff in D82492826.

RandySheriff force-pushed the export-D82492826 branch from f413701 to dcffd5e Compare

September 20, 2025 02:51

RandySheriff added a commit to RandySheriff/ao that referenced this pull request


          Minor fix on TAO op to support lowering (pytorch#3031)

dcffd5e

Summary:

Based on D82580844, further fixing a few functionality gaps to let TAO operator works with AOTI lowering, and the triton compiler ~

Differential Revision: D82492826

Contributor

facebook-github-bot commented Sep 20, 2025

@RandySheriff has exported this pull request. If you are a Meta employee, you can view the originating diff in D82492826.

RandySheriff added a commit to RandySheriff/ao that referenced this pull request


          Minor fix on TAO op to support lowering (pytorch#3031)

04ef35b

Summary:

Based on D82580844, further fixing a few functionality gaps to let TAO operator works with AOTI lowering, and the triton compiler ~

Differential Revision: D82492826

RandySheriff force-pushed the export-D82492826 branch from dcffd5e to 04ef35b Compare

September 20, 2025 03:00

Contributor

facebook-github-bot commented Sep 20, 2025

@RandySheriff has exported this pull request. If you are a Meta employee, you can view the originating diff in D82492826.

RandySheriff force-pushed the export-D82492826 branch from 04ef35b to e8c8732 Compare

September 20, 2025 03:02

RandySheriff added a commit to RandySheriff/ao that referenced this pull request


          Minor fix on TAO op to support lowering (pytorch#3031)

e8c8732

Summary:

Based on D82580844, further fixing a few functionality gaps to let TAO operator works with AOTI lowering, and the triton compiler ~

Differential Revision: D82492826

Contributor

facebook-github-bot commented Sep 20, 2025

@RandySheriff has exported this pull request. If you are a Meta employee, you can view the originating diff in D82492826.

jcaip self-requested a review

September 22, 2025 16:48

jcaip approved these changes

View reviewed changes


          Minor fix on TAO op to support lowering (pytorch#3031)

3122c28

Summary:

Based on D82580844, further fixing a few functionality gaps to let TAO operator works with AOTI lowering, and the triton compiler ~

Reviewed By: jcaip

Differential Revision: D82492826

RandySheriff force-pushed the export-D82492826 branch from e8c8732 to 3122c28 Compare

September 22, 2025 17:04

Contributor

facebook-github-bot commented Sep 22, 2025

@RandySheriff has exported this pull request. If you are a Meta employee, you can view the originating diff in D82492826.

facebook-github-bot merged commit eadead5 into pytorch:main

4 of 5 checks passed

Contributor

jerryzh168 commented Sep 23, 2025 •

edited

Loading

@RandySheriff @jcaip can you help fix ruff error that's introduced in this PR?

Contributor

jcaip commented Sep 23, 2025

@jerryzh168 I think this was resolved by #3039, sorry about that. Let me know if youre running into issues elsewhere and I can take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported meta-exported