fix local float8 tests on H100 #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: float8 tests were failing my machine. I bisected the failure to #1344. Further investigation found that that PR was fine, but the tolerance for one of the tests was too tight, adding a test changed the random seed of the data, and things started failing. Switching to SQNR for a more robust measurement. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1438
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3db7ebd with merge base 2e032c6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vkuzo
added
the
topic: not user facing
drisspg
approved these changes
Dec 18, 2024
amdfaa
pushed a commit
that referenced
this pull request
Jan 10, 2025
Summary: float8 tests were failing my machine. I bisected the failure to #1344. Further investigation found that that PR was fine, but the tolerance for one of the tests was too tight, adding a test changed the random seed of the data, and things started failing. Switching to SQNR for a more robust measurement. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
float8 tests were failing my machine. I bisected the failure to #1344. Further investigation found that that PR was fine, but the tolerance for one of the tests was too tight, adding a test changed the random seed of the data, and things started failing.
Switching to SQNR for a more robust measurement.
Test Plan: CI
Reviewers:
Subscribers:
Tasks:
Tags: