Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Per Tensor Scaling for Float8 Dynamic Autoquant #1175

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Oct 25, 2024

Added support for FP8 Per Tensor Scaling for autoquant

Test Plan:

  • Added sample test in test_integration
  • Tested using llama/generate.py

Copy link

pytorch-bot bot commented Oct 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1175

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 03829b2 with merge base e85c1a3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2024
@jainapurva jainapurva force-pushed the fp8_autoquant_tensor_scaling branch from 64d3d7a to 03829b2 Compare October 28, 2024 19:53
@jainapurva jainapurva merged commit 79ea660 into main Oct 28, 2024
17 checks passed
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
)

* Removed unused only_config arg; Added typehints to builder

* Remove missed arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants