-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AQT#2 LayoutType -> Layout #1049
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1049
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ffd36e3 with merge base fa6d156 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
1958a97
to
1b027ef
Compare
b9f7da9
to
ddf1143
Compare
ddf1143
to
ffd36e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you update the summary with bc breaking note? maybe we just need one for both PRs
…ai_api (pytorch#1049) * Merge the OpenAI files and rename them to openai_api * Updating import with new file name
PR changes:
Current Layout/Layout type confusing and not corresponding to pytorch layout
- “LayoutType” to “Layout”
- “aqt.layout_type” to “aqt._layout” for more alignment with pytorch native Tensor
- _layout -> layout for public API
This change also breaks backwards compatibility for all users that explicitly defined the layout_type parameter:
BC-breaking note:
Prev PR: #1046 -> Layout renamed to TensorImpl
- int4_weight_only
- int8_dynamic_activation_int8_weight
- int8_dynamic_activation_int8_semi_sparse_weight