Allow deprecated declarations what using Parallel ExecuTorch #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1031
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dfd4cda with merge base 900f9ac ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64020498 |
…#1031) Summary: With the recent BC/FC work by ExecuTorch, many APIs have been marked as deprecated. While the functionality itself is not broken, this results in some build systems treating deprecatd APIs as a failure case. Specifically `_unsafe_reset_threadpool` This PR add compile flag to not error on deprecation warnings Differential Revision: D64020498
Jack-Khuu
force-pushed
the
export-D64020498
branch
from
5d84e9c to
dfd4cda
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64020498 |
jerryzh168
approved these changes
Oct 9, 2024
jainapurva
pushed a commit
that referenced
this pull request
Oct 9, 2024
Differential Revision: D64020498 Pull Request resolved: #1031
jainapurva
pushed a commit
that referenced
this pull request
Oct 15, 2024
Differential Revision: D64020498 Pull Request resolved: #1031
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
Summary: use_tp was renamed to use_distributed in pytorch/torchchat#873, but the PR missed generate.py, which caused "AttributeError: 'BuilderArgs' object has no attribute 'use_tp'" when running generate with --profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With the recent BC/FC work by ExecuTorch, many APIs have been marked as deprecated. While the functionality itself is not broken, this results in some build systems treating deprecatd APIs as a failure case.
Specifically
_unsafe_reset_threadpoolThis PR add compile flag to not error on deprecation warnings
Differential Revision: D64020498