Skip to content

Cherry pick jetson enablement from 2.8 release branch to main #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla bot added the cla signed label Aug 8, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: build system Issues re: Build system component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 8, 2025
@github-actions github-actions bot requested a review from narendasan August 8, 2025 06:50
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/custom_ops_converters.py	2025-08-08 06:50:04.271977+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/custom_ops_converters.py	2025-08-08 06:50:29.351625+00:00
@@ -19,10 +19,11 @@
if load_tensorrt_llm():
    from torch_tensorrt.dynamo.lowering.passes.fuse_distributed_ops import (
        tensorrt_fused_nccl_all_gather_op,
        tensorrt_fused_nccl_reduce_scatter_op,
    )
+
    @dynamo_tensorrt_converter(tensorrt_fused_nccl_all_gather_op)
    def fused_nccl_gather(
        ctx: ConversionContext,
        target: Target,
        args: Tuple[Argument, ...],
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/passes/_aten_lowering_pass.py	2025-08-08 06:50:04.274977+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/passes/_aten_lowering_pass.py	2025-08-08 06:50:30.337911+00:00
@@ -33,10 +33,11 @@
    remove_detach,
]

if not is_tegra_platform():
    from .fuse_distributed_ops import fuse_distributed_ops
+
    post_lowering_pass_list.append(fuse_distributed_ops)

ATEN_POST_LOWERING_PASSES = DynamoPassManager.build_from_passlist(
    post_lowering_pass_list
)
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py	2025-08-08 06:50:04.271977+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py	2025-08-08 06:50:32.115974+00:00
@@ -617,10 +617,11 @@
            args[0],
            args[1],
            args[2],
            args[3],
        )
+

if is_tensorrt_version_supported("10.8.0"):
    try:
        import modelopt.torch.quantization as mtq  # noqa: F401

@github-actions github-actions bot added the component: converters Issues re: Specific op converters label Aug 8, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/custom_ops_converters.py	2025-08-08 06:55:35.012666+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/custom_ops_converters.py	2025-08-08 06:56:00.306350+00:00
@@ -19,10 +19,11 @@
if load_tensorrt_llm():
    from torch_tensorrt.dynamo.lowering.passes.fuse_distributed_ops import (
        tensorrt_fused_nccl_all_gather_op,
        tensorrt_fused_nccl_reduce_scatter_op,
    )
+
    @dynamo_tensorrt_converter(tensorrt_fused_nccl_all_gather_op)
    def fused_nccl_gather(
        ctx: ConversionContext,
        target: Target,
        args: Tuple[Argument, ...],
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/passes/_aten_lowering_pass.py	2025-08-08 06:55:35.015667+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/passes/_aten_lowering_pass.py	2025-08-08 06:56:01.320835+00:00
@@ -33,10 +33,11 @@
    remove_detach,
]

if not is_tegra_platform():
    from .fuse_distributed_ops import fuse_distributed_ops
+
    post_lowering_pass_list.append(fuse_distributed_ops)

ATEN_POST_LOWERING_PASSES = DynamoPassManager.build_from_passlist(
    post_lowering_pass_list
)
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py	2025-08-08 06:55:35.012666+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py	2025-08-08 06:56:03.108230+00:00
@@ -617,10 +617,11 @@
            args[0],
            args[1],
            args[2],
            args[3],
        )
+

if is_tensorrt_version_supported("10.8.0"):
    try:
        import modelopt.torch.quantization as mtq  # noqa: F401

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/custom_ops_converters.py	2025-08-08 07:19:01.667895+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/custom_ops_converters.py	2025-08-08 07:19:27.514217+00:00
@@ -19,10 +19,11 @@
if load_tensorrt_llm():
    from torch_tensorrt.dynamo.lowering.passes.fuse_distributed_ops import (
        tensorrt_fused_nccl_all_gather_op,
        tensorrt_fused_nccl_reduce_scatter_op,
    )
+
    @dynamo_tensorrt_converter(tensorrt_fused_nccl_all_gather_op)
    def fused_nccl_gather(
        ctx: ConversionContext,
        target: Target,
        args: Tuple[Argument, ...],
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/passes/_aten_lowering_pass.py	2025-08-08 07:19:01.670895+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/passes/_aten_lowering_pass.py	2025-08-08 07:19:28.513808+00:00
@@ -33,10 +33,11 @@
    remove_detach,
]

if not is_tegra_platform():
    from .fuse_distributed_ops import fuse_distributed_ops
+
    post_lowering_pass_list.append(fuse_distributed_ops)

ATEN_POST_LOWERING_PASSES = DynamoPassManager.build_from_passlist(
    post_lowering_pass_list
)
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py	2025-08-08 07:19:01.667895+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py	2025-08-08 07:19:30.393872+00:00
@@ -617,10 +617,11 @@
            args[0],
            args[1],
            args[2],
            args[3],
        )
+

if is_tensorrt_version_supported("10.8.0"):
    try:
        import modelopt.torch.quantization as mtq  # noqa: F401

@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review August 8, 2025 07:48
@lanluo-nvidia lanluo-nvidia added the ciflow/binaries/all Build for all Python Versions label Aug 8, 2025
Copy link

pytorch-bot bot commented Aug 8, 2025

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@github-actions github-actions bot requested a review from gs-olive August 8, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries/all Build for all Python Versions cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants