feat: Save target platform as part of TRTEngine Metadata #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
narendasan
force-pushed
the
platform_checking
branch
2 times, most recently
from
4b50ad3 to
f2e902b
Compare
narendasan
commented
Aug 21, 2024
core/runtime/Platform.cpp
Outdated
| #elif defined(__amd64__) || defined(__x86_64__) | ||
| return Platform(Platform::PlatformEnum::kLINUX_X86_64); | ||
| #else | ||
| return Platform(Platform::PlatformEnum::kLINUX_X86_64); |
There was a problem hiding this comment.
This should be unknown
peri044
approved these changes
Aug 21, 2024
| @@ -196,7 +209,6 @@ TRTEngine::TRTEngine( | |||
| } | |||
|
|
|||
| TRTEngine::~TRTEngine() { | |||
| cudagraph.reset(); | |||
There was a problem hiding this comment.
The object destructor calls it and its potentially unsafe to do it ourselves
narendasan
commented
Aug 23, 2024
py/torch_tensorrt/_enums.py
Outdated
|
|
||
| elif platform.system().lower().startswith("win32"): | ||
| # Windows... | ||
| if platform.machine().startswith("x86_64"): |
narendasan
force-pushed
the
platform_checking
branch
2 times, most recently
from
5ae6942 to
80de386
Compare
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
narendasan
force-pushed
the
platform_checking
branch
from
80de386 to
f9ff5b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Saves the target platform as part of the TRTEngine Data.
Fixes #3103
Fixes #3101
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: