tile dynamic dim #3085
Merged
tile dynamic dim #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
peri044
reviewed
Aug 15, 2024
| shapes = [i * j for i, j in zip(input.shape, dims)] | ||
| layer = ctx.net.add_slice(input, tuple(starts), tuple(shapes), tuple(strides)) | ||
| else: | ||
| shapes = None |
There was a problem hiding this comment.
should shapes be a list here ?
| input, start=trt.Dims(), shape=trt.Dims(), stride=trt.Dims() | ||
| ) | ||
| layer.set_input(1, tuple(starts)) | ||
| layer.set_input(2, tuple(shapes)) |
There was a problem hiding this comment.
Looks like we are setting a list of ITensors as a second input. But shouldn't the second input be an ITensor (which is the concatenated output of these shapes ) ? or both of them work ?
| ((2,), (3,), (6,), (2, 2)), | ||
| ((2,), (3,), (6,), (0, 2)), | ||
| # 2d cases | ||
| ((3, 1), (3, 1), (6, 1), (0,)), |
There was a problem hiding this comment.
is tiling with dims = (0,) same as tiling with (1,) ?
There was a problem hiding this comment.
Tiling with dims = (0,) results in that particular dimension as 0 in the tiled tensor. In the above case though it prepends -1 resulting in dims being (-1, 0) post which the dynamic input tensor is tiled
apbose
force-pushed
the
tile_dynamic_dim
branch
from
d70b716 to
e14badb
Compare
apbose
force-pushed
the
tile_dynamic_dim
branch
from
e14badb to
0770cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.