Group norm bug fix #3014
Merged
Group norm bug fix #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
cehongwang
force-pushed
the
group-norm-bug-fix
branch
2 times, most recently
from
5f47fb1 to
e8d942f
Compare
cehongwang
force-pushed
the
group-norm-bug-fix
branch
2 times, most recently
from
937d342 to
8649c5b
Compare
…omposed ops instead of using INormalization Layer. Supported dynamic shape
cehongwang
force-pushed
the
group-norm-bug-fix
branch
from
8649c5b to
03aca50
Compare
apbose
reviewed
Jul 19, 2024
apbose
reviewed
Jul 23, 2024
| reshaped_input.shape, | ||
| ) | ||
|
|
||
| eps_trt = get_trt_tensor(ctx, eps, f"{name}_eps", np.float32) |
There was a problem hiding this comment.
Why is this converted to np.float32?
There was a problem hiding this comment.
It is 1e-6 in most cases.
There was a problem hiding this comment.
float16 cannot handle that close to 0
apbose
reviewed
Jul 23, 2024
| f"{name}_div", | ||
| sub_trt, | ||
| sqrt_trt, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Wanted to clarify if this div would require any mode, eg: trunc? Are the data types always compatible with the output types?
There was a problem hiding this comment.
I don't think so. The previous implementation from Evan did not include any mode.
There was a problem hiding this comment.
just FYI: we have impl.elementwise.floor_divide and impl.elementwise.trunc_div helper functions, if needed.
zewenli98
reviewed
Jul 23, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: