-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support aten.log1p converter #2823
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1165,6 +1165,57 @@ def aten_ops_log( | |
) | ||
|
||
|
||
@dynamo_tensorrt_converter(torch.ops.aten.log2.default) | ||
def log2( | ||
ctx: ConversionContext, | ||
target: Target, | ||
args: Tuple[Argument, ...], | ||
kwargs: Dict[str, Argument], | ||
name: str, | ||
) -> Union[TRTTensor, Sequence[TRTTensor]]: | ||
return impl.unary.log2( | ||
ctx, | ||
target, | ||
SourceIR.ATEN, | ||
name, | ||
args[0], | ||
) | ||
|
||
|
||
@dynamo_tensorrt_converter(torch.ops.aten.log10.default) | ||
def log10( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. |
||
ctx: ConversionContext, | ||
target: Target, | ||
args: Tuple[Argument, ...], | ||
kwargs: Dict[str, Argument], | ||
name: str, | ||
) -> Union[TRTTensor, Sequence[TRTTensor]]: | ||
return impl.unary.log10( | ||
ctx, | ||
target, | ||
SourceIR.ATEN, | ||
name, | ||
args[0], | ||
) | ||
|
||
|
||
@dynamo_tensorrt_converter(torch.ops.aten.log1p.default) | ||
def aten_ops_log1p( | ||
ctx: ConversionContext, | ||
target: Target, | ||
args: Tuple[Argument, ...], | ||
kwargs: Dict[str, Argument], | ||
name: str, | ||
) -> Union[TRTTensor, Sequence[TRTTensor]]: | ||
return impl.unary.log1p( | ||
ctx, | ||
target, | ||
SourceIR.ATEN, | ||
name, | ||
args[0], | ||
) | ||
|
||
|
||
@dynamo_tensorrt_converter(torch.ops.aten.sqrt.default) | ||
def aten_ops_sqrt( | ||
ctx: ConversionContext, | ||
|
@@ -2829,23 +2880,6 @@ def aten_ops_flip( | |
) | ||
|
||
|
||
@dynamo_tensorrt_converter(torch.ops.aten.log2.default) | ||
def log2( | ||
ctx: ConversionContext, | ||
target: Target, | ||
args: Tuple[Argument, ...], | ||
kwargs: Dict[str, Argument], | ||
name: str, | ||
) -> Union[TRTTensor, Sequence[TRTTensor]]: | ||
return impl.unary.log2( | ||
ctx, | ||
target, | ||
SourceIR.ATEN, | ||
name, | ||
args[0], | ||
) | ||
|
||
|
||
@dynamo_tensorrt_converter(torch.ops.aten.scalar_tensor.default) | ||
def aten_ops_scalar_tensor( | ||
ctx: ConversionContext, | ||
|
@@ -2859,23 +2893,6 @@ def aten_ops_scalar_tensor( | |
) | ||
|
||
|
||
@dynamo_tensorrt_converter(torch.ops.aten.log10.default) | ||
def log10( | ||
ctx: ConversionContext, | ||
target: Target, | ||
args: Tuple[Argument, ...], | ||
kwargs: Dict[str, Argument], | ||
name: str, | ||
) -> Union[TRTTensor, Sequence[TRTTensor]]: | ||
return impl.unary.log10( | ||
ctx, | ||
target, | ||
SourceIR.ATEN, | ||
name, | ||
args[0], | ||
) | ||
|
||
|
||
@dynamo_tensorrt_converter(torch.ops.aten.roll.default) | ||
@enforce_tensor_types( | ||
{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
import torch | ||
import torch.nn as nn | ||
from parameterized import parameterized | ||
from torch.testing._internal.common_utils import run_tests | ||
from torch_tensorrt import Input | ||
|
||
from .harness import DispatchTestCase | ||
|
||
|
||
class TestLog1pConverter(DispatchTestCase): | ||
@parameterized.expand( | ||
[ | ||
((10,), torch.float), | ||
((1, 20), torch.float), | ||
((2, 3, 4), torch.float), | ||
((2, 3, 4, 5), torch.float), | ||
] | ||
) | ||
def test_log1p_float(self, input_shape, dtype): | ||
class Log1p(nn.Module): | ||
def forward(self, input): | ||
return torch.ops.aten.log1p.default(input) | ||
|
||
inputs = [ | ||
torch.randn(input_shape, dtype=dtype).abs() + 0.001 | ||
] # ensure positive input | ||
self.run_test( | ||
Log1p(), | ||
inputs, | ||
) | ||
|
||
@parameterized.expand( | ||
[ | ||
((10,), torch.int, 0, 5), | ||
((1, 20), torch.int, 0, 10), | ||
((2, 3, 4), torch.int, 0, 5), | ||
((2, 3, 4, 5), torch.int, 0, 5), | ||
] | ||
) | ||
def test_log1p_int(self, input_shape, dtype, low, high): | ||
class Log1p(nn.Module): | ||
def forward(self, input): | ||
return torch.ops.aten.log1p.default(input) | ||
|
||
inputs = [ | ||
torch.randint(low, high, input_shape, dtype=dtype).abs() + 0.001 | ||
] # ensure positive input | ||
self.run_test( | ||
Log1p(), | ||
inputs, | ||
) | ||
|
||
@parameterized.expand( | ||
[ | ||
(torch.full((1, 20), 2, dtype=torch.float),), | ||
(torch.full((2, 3, 4), 3, dtype=torch.float),), | ||
(torch.full((2, 3, 4, 5), 4, dtype=torch.float),), | ||
] | ||
) | ||
def test_log1p_const_float(self, data): | ||
class Log1p(nn.Module): | ||
def forward(self, input): | ||
return torch.ops.aten.log1p.default(input) | ||
|
||
inputs = [data] | ||
self.run_test( | ||
Log1p(), | ||
inputs, | ||
) | ||
|
||
|
||
if __name__ == "__main__": | ||
run_tests() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed the naming was inconsistent. Can you modify the function name to
aten_ops_log2
?