-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade TensorRT version to TRT 10 EA (#2699) #2774
Conversation
Co-authored-by: Evan Li <zewenl@nvidia.com>
ctx.net, lhs_val, rhs_val, f"{name}_lhs", f"{name}_rhs" | ||
) | ||
else: | ||
lhs_val_shape = lhs_val.shape |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the code changes to address the error caused by broadcasting, and it seems to be related to this issue.
If we perform element-wise operations on two inputs with shapes lhs (2, 2, 14, 1, 5)
and rhs (2, 1, 3, 5)
, the output of the element-wise operation layer should be (2, 2, 14, 3, 5)
.
However, with the current code, the output of the element-wise operation layer follows the larger rank of lhs_val and becomes (2, 2, 14, 1, 5)
.
As a result, an error that did not occur on the local machine was found during CI/CD (#2726)
Is it necessary to make adjustments to fix this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is necessary to fix this code as any converter that uses this would likely have that failure. It sounds like the fix would be broadcasting across mismatched dimensions instead of using rank heuristic. @zewenli98 probably you have an idea about these specific changes while fixing test_binary_ops ?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: