Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grid_sampler converter not properly registered #2682

Closed
wants to merge 1 commit into from
Closed

Fix grid_sampler converter not properly registered #2682

wants to merge 1 commit into from

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Mar 10, 2024

Description

Partially #2665

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 10, 2024
@github-actions github-actions bot requested a review from peri044 March 10, 2024 05:30
@apbose apbose mentioned this pull request Mar 11, 2024
Merged
@apbose
Copy link
Collaborator

apbose commented Mar 12, 2024

This PR looks good just that it would require some additional tests as in #2686

@HolyWu HolyWu closed this Mar 12, 2024
@HolyWu HolyWu deleted the grid_sampler branch March 12, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 Awaiting requested review from peri044

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HolyWu @apbose @facebook-github-bot