Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix: Parse out slashes in Docker container name #2437

Merged
merged 1 commit into from
Nov 6, 2023
Merged

minor fix: Parse out slashes in Docker container name #2437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/docker_builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v3

- name: Fix Slashes Repo Name
id: fix_slashes
run: |
export container_name=$(echo ${{ env.CONTAINER_NAME }} | sed 's|/|_|g')
echo ::set-output name=container_name::$container_name

- name: Log in to the Container registry
uses: docker/login-action@v2
with:
Expand All @@ -38,7 +44,7 @@ jobs:
# Automatically detect TensorRT and cuDNN default versions for Torch-TRT build
- name: Build Docker image
env:
DOCKER_TAG: ${{ env.DOCKER_REGISTRY }}/${{ env.CONTAINER_NAME }}
DOCKER_TAG: ${{ env.DOCKER_REGISTRY }}/${{ steps.fix_slashes.outputs.container_name }}
run: |
python3 -m pip install pyyaml
TRT_VERSION=$(python3 -c "import versions; versions.tensorrt_version()")
Expand All @@ -50,7 +56,7 @@ jobs:

- name: Push Docker image
env:
DOCKER_URL: ${{ env.DOCKER_REGISTRY }}/${{ env.CONTAINER_NAME }}
DOCKER_URL: ${{ env.DOCKER_REGISTRY }}/${{ steps.fix_slashes.outputs.container_name }}
run: docker push $DOCKER_URL

# Clean up all untagged containers in registry
Expand Down
Loading