fix: Bugfix in TRT Engine deserialization indexing #1646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The IO Tensors and Bindings within the TensorRT
ICudaEngine
object are not necessarily stored in index-order, or in the order they are stored in PyTorch. Thus, one of the checks in theTRTEngine
which extracts the TRT binding name and compares it to the Torch binding name is unnecessary/incorrect and can be improved.As an example, consider an engine with two inputs:
{“input_0”, “input_1”}
and two outputs{“output_0”, “output_1”}
. The Torch binding names (c10::NameList
) stores these as:The TRT Engine binding buffer stores these names as:
Thus, when we use direct indexing to access the binding names, an error is encountered, despite the fact that the overall set of IO tensors is the same.
TRTEngine.cpp
for existence of binding indexFixes #1550
Fixes #1645
Type of change
Checklist: