fix: Bugfix in Linear-to-AddMM Fusion Lowering Pass #1619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prim::If
whenbias=None
. As an example, these would be ignored:prim::If
even when the original function call occurred within such a block. As an example, the following translates to the subsequent graph, which contains an invalid computation:aten::linear
, only one of which is a valid operation. Thus, evaluating both branches can cause compilation to crash, as invalid Tensor shapes can be encounteredRegisterRewritePattern
paradigm for Tensor biases, as the rewrite does not always place the subgraph in the desired locationAddresses 1st Bug in #1616
Type of change
Checklist: