Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add functionality to FX benchmarking + Improve documentation #1529

Merged
merged 2 commits into from
Dec 13, 2022
Merged

feat: Add functionality to FX benchmarking + Improve documentation #1529

merged 2 commits into from
Dec 13, 2022

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Dec 5, 2022

Description

  • Add support for FX in YAML config specification path of perf_run.py
  • Add support for only specifying one of: a PyTorch or TorchScript model
  • Improve input model validation to throw errors earlier
  • Remove deprecated option from torchvision model
  • Add documentation for FX benchmarking

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
feat: Add functionality to only benchmark FX
f1bf283 
- Add support for FX in YAML config specification path of `perf_run.py`
- Add support for only specifying one of: a PyTorch or TorchScript model
- Improve input model validation to throw errors earlier
- Remove deprecated option from torchvision model
@gs-olive gs-olive requested a review from peri044 December 5, 2022 18:00
@gs-olive
Add support for FX in all backends path
360f6c4 
- Update documentation
- Add new backend for only-TorchScript benchmarks
peri044
peri044 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 6f73a23 into pytorch:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @peri044 @facebook-github-bot