-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcast the two input shapes for transposed matmul #1413
Broadcast the two input shapes for transposed matmul #1413
Conversation
@ncomly-nvidia Could you let us know what we need to do to have this reviewed and merged? Thanks |
@narendasan @frank-wei can you please review or assign? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. Could you add a unittest?
@yinghai Could you help to point out where should I add a unit test which can save me a lot of time. |
bfa971a
to
5c6ffa4
Compare
Hi @FelixXidddd! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
5c6ffa4
to
19c7112
Compare
The corresponding test is added. Please help to review. |
@narendasan Should I sign up at https://code.facebook.com/cla? Should not we (Nvidia employees) already sign? |
LGTM! Pls sign up for it since every contributor needs to do so. |
@FelixXidddd you need to sign the corporate one. @narendasan can you please send the info over? |
19c7112
to
416381a
Compare
modified: py/torch_tensorrt/fx/converters/acc_ops_converters.py modified: py/torch_tensorrt/fx/test/passes/test_fuse_permute_matmul_trt.py
416381a
to
69d371f
Compare
Let's use #1457 instead and close this. Thanks |
Description
There is a transposed matmul layer(cases from meta_benchmark), has two inputs src0 and src1(which is a const).
Error message:
As you can see from the error message, the src0 is [2048,752,200] and src1 is [752,60] which is not broadcast conformable. Actually torch should unsqueeze src1 from [752,60] to [1,752,60]
Fixes # (issue)
So we need to broadcast the inputs of transposed matmul layer.
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: