Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Fixed Windows compilation failures #1330

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Sep 1, 2022

Signed-off-by: Anurag Dixit a.dixit91@gmail.com

Description

This PR fixes the issues in compilation failures on Windows platform.

Fixes # (issue) #1245

Type of change

Please delete options that are not relevant and/or add your own.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
@andi4191 andi4191 requested a review from narendasan September 1, 2022 09:27
@github-actions github-actions bot added component: api [C++] Issues re: C++ API component: core Issues re: The core compiler component: partitioning labels Sep 1, 2022
@andi4191 andi4191 added the channel: windows bugs, questions, & RFEs around Windows label Sep 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit a1a4786 into master Sep 1, 2022
@andi4191 andi4191 deleted the anuragd/fix_windows_compilation branch September 1, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel: windows bugs, questions, & RFEs around Windows cla signed component: api [C++] Issues re: C++ API component: core Issues re: The core compiler component: partitioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants