Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1142

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Update README.md #1142

merged 4 commits into from
Jun 23, 2022

Conversation

frank-wei
Copy link
Contributor

@frank-wei frank-wei commented Jun 23, 2022 •
edited
Loading

Description

Update the FX path installation doc

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

colin2328
colin2328 approved these changes Jun 23, 2022
View reviewed changes
Copy link

@colin2328 colin2328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

github-actions[bot]
github-actions bot approved these changes Jun 23, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

yinghai
yinghai reviewed Jun 23, 2022
View reviewed changes
README.md Outdated
@@ -212,6 +212,12 @@ new_local_repository(
bazel build //:libtorchtrt --compilation_mode opt
```

### FX path only installatioin
If the user plan to try FX path only and would like avoid bazel build.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

FX path (Python only)

github-actions[bot]
github-actions bot approved these changes Jun 23, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@frank-wei frank-wei merged commit 17898d0 into master Jun 23, 2022
github-actions[bot]
github-actions bot approved these changes Jun 23, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 23, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@frank-wei frank-wei deleted the frank-wei-patch-1 branch June 23, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin2328 colin2328 colin2328 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@yinghai yinghai yinghai approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frank-wei @yinghai @colin2328 @facebook-github-bot