Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Triton deployment instructions to documentation #1116

Merged
merged 6 commits into from
Jun 16, 2022

Conversation

tanayvarshney
Copy link
Contributor

Description

Added documentation about deploying a model to triton

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • This change requires a documentation update

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 14, 2022
@github-actions github-actions bot requested a review from narendasan June 14, 2022 17:15
@ncomly-nvidia
Copy link
Contributor

@narendasan can we have this merged before EoW? This is needed for marketing release.

@tanayvarshney tanayvarshney changed the title Docs Added Triton deployment instructions to documentation Jun 15, 2022
@ncomly-nvidia ncomly-nvidia requested a review from peri044 June 15, 2022 16:51
@ncomly-nvidia
Copy link
Contributor

Changing reviewer to @peri044

docsrc/tutorials/deploy_torch_tensorrt_to_triton.rst Outdated Show resolved Hide resolved
docsrc/tutorials/deploy_torch_tensorrt_to_triton.rst Outdated Show resolved Hide resolved
# <xx.xx> is the yy:mm for the publishing tag for NVIDIA's Pytorch
# container; eg. 22.04

docker run -it --gpus all -v /path/to/folder:/resnet50_eg nvcr.io/nvidia/pytorch:<xx.xx>-py3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-v /path/to/folder:/resnet50_eg - is this required here ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, please elaborate in the README as to which folder we should mount to docker

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path/to/local/folder/to/copy/model:/resnet50_eg is this required here ?
Like torch.hub will automatically download the RN50 model right as per model = torch.hub.load('pytorch/vision:v0.10.0', 'resnet50', pretrained=True).eval().to("cuda") ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, resnet50_eg it is not being used anywhere in the instructions. We don't need this I think

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this resolved ?

docsrc/tutorials/deploy_torch_tensorrt_to_triton.rst Outdated Show resolved Hide resolved
@ncomly-nvidia ncomly-nvidia removed the request for review from narendasan June 16, 2022 20:40
@peri044 peri044 merged commit 2585b77 into pytorch:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants